-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting code with gofmt #2255
Conversation
Signed-off-by: huochexizhan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Should linting be added as part of the Github action checks?
If the final conclusion needs to be added, I'm happy to submit a new PR to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Would be nice to add linting/formatting to this project. The dockerized tools
approach we use in lnd
should be easy to port over: https://github.com/lightningnetwork/lnd/tree/master/tools
Pull Request Test Coverage Report for Build 11030695951Details
💛 - Coveralls |
Thank you very much! I see you have approved it. Should I try to modify it on this PR or create a new one? |
I think a new PR would be better, going to merge this one now. |
Thanks! |
No description provided.