Collect small fixes from stale contributor PRs #969
Conversation
rpc/legacyrpc/methods.go
Outdated
| if result == nil { | ||
| return nil, errUtxoSpent | ||
| } |
There was a problem hiding this comment.
ok cool - i guess ideally we could change Receive to return an error if the result is nil and then dont need to explicitly handle this. but i see we already do this special case handling in lnd for all calls to Receive done via GetTxOut.
go.mod
Outdated
| @@ -21,6 +21,7 @@ require ( | |||
| github.com/lightninglabs/gozmq v0.0.0-20191113021534-d20a764486bf | |||
| github.com/lightninglabs/neutrino v0.16.0 | |||
| github.com/lightninglabs/neutrino/cache v1.1.2 | |||
| github.com/lightningnetwork/lnd/fn v1.2.5 | |||
There was a problem hiding this comment.
didn't realize we were importing modules from lnd before😮💨
There was a problem hiding this comment.
Yeah. But those are all submodules, so it shouldn't really matter. But noticed this actually needs to be github.com/lightningnetwork/lnd/fn/v2, so I changed that.
guggero
force-pushed
the
small-pr-consolidation
branch
from
8412709 to
2a436f5
Compare
Depends on btcsuite/btcwallet#969. Makes sure the changes in that small PR don't cause any failures in lnd.
Signed-off-by: Ononiwu Maureen <[email protected]>
We disable some of the linters that give us too many false positives. Those linters are also disabled in other projects such as lnd for example.
guggero
force-pushed
the
small-pr-consolidation
branch
from
2a436f5 to
3b576ed
Compare
Depends on btcsuite/btcwallet#969. Makes sure the changes in that small PR don't cause any failures in lnd.
|
|
|
hmm think |
|
Yeah, I'll take a look at some point. Seems like the early rescan abort shortcut breaks things. Perhaps because we re-use existing rescans, but then it's already aborted? |
Replaces #959.
Replaces #824.
Replaces #928.