Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "componentsPath" option #59

Open
whyleee opened this issue Dec 27, 2014 · 1 comment · May be fixed by #60
Open

Add "componentsPath" option #59

whyleee opened this issue Dec 27, 2014 · 1 comment · May be fixed by #60

Comments

@whyleee
Copy link

whyleee commented Dec 27, 2014

There is a common situation when the path to "bower_components" dir is "scripts/bower_components"or similar. And for some reason there is a code to strip leading path segment off, based on assumption that entire app will be one level down after "bower.json". But this is not true for a lot of projects (and moreover, this code doesn't work in Windows #39).

Supposing i have "scripts/bower_components" path and this script tag in html:
<script src="/scripts/bower_components/jquery/dist/jquery.js"></script>
it will be replaced by the next tag after build:
<script src="/scripts//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
which is naturally wrong and should be:
<script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>

Please do not depend on project structure, but add an option to set "bower_components" path manually. This is easy, because google-cdn already has this option.

@kynan
Copy link

kynan commented Mar 20, 2016

This should also respect the cwd setting in .bowerrc, see #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants