-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable not working in or after #18
Comments
I tried using yours wich was 1.2.4 if i remember but it didnt worked for me so i tried searching for an conatact on you. But didnt find. You mean from your releases? |
Yeah, this one: https://github.com/yokunjon/reqn/releases/tag/v1.2.4 If that doesn't work, I don't know anything else, I don't work with Skript anymore so no idea on that. I hope you can find a solution. |
If i just want to try i should first download release and then build right? |
If you download from the releases, that's already built by me, so you don't have to. What I'm trying to tell is, just don't run/use code you don't understand or trust the source of. I might've provided that solution, but theorically speaking, I might be someone with malicous intent. I just wanted to give a general warning about downloading stuff from releases or building random code. Other than that, you can simply download it from releases and use it as plugin without any further steps. 😄 |
Yeah i know that... I was kinda skeptical putting trust in you but i look into what u changed.. But i got some long error. Im gonna try and im gonna send it to you. |
here it is om your fork... https://pastebin.com/YaTWSyHe |
Hmm, for no apparent reason it tries to convert HashMap into ConcurrentHashMap. My bet is async runtime that the Bukkit task uses does it to guarantee safety. This wasn't the case when I first wrote it, probably related to updates on Java or Bukkit/Spigot/Paper. I'll try if simply changing HashMap into ConcurrentHashMap see if works and commit & build it if that's the case. |
@ItzDepstRT Alright, it is indeed about wrong cast but I was a little blind there due to reflection I made, so what I said above is incorrect if anyone is wondering (and it is vice-versa, ConcurrentHashMap into HashMap). Looks like Skript changed localVariables that I reflect into ConcurrentHashMap in newer versions. I updated the cast, it should work now. 🥳 |
Tysm so much... I will try it so happy for it |
Daum bro.,... It works im so happy for it tysm |
Haha, you're welcome. Happy to hear that! 😄 |
This is the link to @yokunjon 's fork of Reqn (1.2.5) The problem was fixed. All thanks to him! |
The text was updated successfully, but these errors were encountered: