Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clipboards on POSIX may not persist properly #43

Open
btzy opened this issue Jul 25, 2018 · 1 comment
Open

Clipboards on POSIX may not persist properly #43

btzy opened this issue Jul 25, 2018 · 1 comment
Labels
Platform: Linux Priority: Medium Type: Bug Bugs and unexpected behavior

Comments

@btzy
Copy link
Owner

btzy commented Jul 25, 2018 •
edited
Loading

  1. Open an instance of Circuit Sandbox.
  2. Write to a clipboard.
  3. Open another instance of Circuit Sandbox.
  4. Close the first instance.
  5. Open another instance of Circuit Sandbox. This new instance might not be able to read the data saved by the first instance.

See how Boost.Interprocess and shm_unlink works.
@btzy btzy added Type: Bug Bugs and unexpected behavior Platform: Linux Priority: Medium labels Jul 26, 2018
btzy added a commit that referenced this issue Aug 4, 2018
@btzy
Implement reference counting for clipboard shared memory on POSIX
6c5f04b 
- This is a not-very-ideal solution for process-persistant shared memory on linux (#43).
- It is implemented by incrementing a counter stored on the shared memory when the shared memory is created or opened, and decrementing the counter when the shared memory is closed (the process that decremented the counter to zero is responsible for removing the shared memory).
- If Circuit Sandbox crashes or is otherwise killed, the shared memory won't be removed until a system reboot.
@btzy
Copy link
Owner Author

btzy commented Aug 5, 2018 •
edited
Loading

6c5f04b introduces reference counting for the POSIX shared memory. It fixes the bug for the sequence of actions above, and it works as intended as long as Circuit Sandbox does not crash or exit in an abnormal manner. If it crashes or exits abnormally, the reference count will not be decremented and the shared memory will not be removed until the system is rebooted (because POSIX shared memory has kernel persistence).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform: Linux Priority: Medium Type: Bug Bugs and unexpected behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@btzy