Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add round-trip and save format tests #3

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add round-trip and save format tests #3

wants to merge 20 commits into from

Commits on Sep 2, 2024

  1. add first tests. only one of them works, because: 

    - there is no domain reload between tests
- the SaveManager stores state in a singleton, so it only resets on domain reload
- there is no way to deregister a saveable if it is destroyed
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5e7353e View commit details
    Browse the repository at this point in the history

  2. got 2nd test working, by forcing per-test unique keys

    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    771b279 View commit details
    Browse the repository at this point in the history

  3. fix swallowing exceptions in the async to coroutine converter 

    improve async -> coroutine by reading the UniTask library source code
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    274b1a0 View commit details
    Browse the repository at this point in the history

  4. fix hidden exception. the Awaitable WaitForSecondsAsync api is incomp… 

    …atible with running on different threads. instead relying on C# System.Threading.Tasks
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f930eef View commit details
    Browse the repository at this point in the history

  5. add presumed best-case save file format tests, failing currently

    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    bbb2cc7 View commit details
    Browse the repository at this point in the history

  6. fix the save file format tests to conform w/ current function w/o the… 

    … unity json converters
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    efde455 View commit details
    Browse the repository at this point in the history

  7. DRY up the test cases 

    organize test files. extract a shared function to a base test class

add some documentation to the tests
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e8952d0 View commit details
    Browse the repository at this point in the history

  8. add test for Vector3 serialization. seems to work

    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9a3ef02 View commit details
    Browse the repository at this point in the history

  9. add test to test the unity json converterrs 

    fixup the unity converter test based on real functionality
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5572e9a View commit details
    Browse the repository at this point in the history

  10. flesh out the test ASMDEF

    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    3c0b8ca View commit details
    Browse the repository at this point in the history

  11. add TODO and variant test around a failing, potential bugged, test

    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9ee4ef0 View commit details
    Browse the repository at this point in the history

  12. more docs, and cleanup

    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b8179ec View commit details
    Browse the repository at this point in the history

  13. remove creation of a saveManager game object from the tests - not nec… 

    …essary, Singleton will auto-create
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d8ebdad View commit details
    Browse the repository at this point in the history

  14. add documentation for SaveManager internal state

    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    51eca0e View commit details
    Browse the repository at this point in the history

  15. create conditionally-compiling test assembly to test integration with… 

    … UnityConverters
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    649fdf9 View commit details
    Browse the repository at this point in the history

  16. more DRY - functional helper for round-trip testing

    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7503cab View commit details
    Browse the repository at this point in the history

  17. rename tests. add a new test to make evident the Vector3 save format … 

    …when using unity converters
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    ac30d33 View commit details
    Browse the repository at this point in the history

  18. add comments indicating the thread context of ISaveable methods 

    Add doc comments to some test methods
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    723fad0 View commit details
    Browse the repository at this point in the history

  19. pre-review touchup

    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    494db75 View commit details
    Browse the repository at this point in the history

  20. use recommendation from unity to test Awaitable async functions. don'… 

    …t need a custom to-coroutine converter: https://docs.unity3d.com/6000.0/Documentation/Manual/AwaitSupport.html
    @dsmiller95
    dsmiller95 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    09bf456 View commit details
    Browse the repository at this point in the history