Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dip.corr_2d for stride=13 and other similar cases #73

Open
meshtag opened this issue Sep 8, 2022 · 0 comments
Open

Fix dip.corr_2d for stride=13 and other similar cases #73

meshtag opened this issue Sep 8, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@meshtag
Copy link
Member

meshtag commented Sep 8, 2022

Is your feature request related to a problem? Please describe.
Our implementation for lowering pass of dip.corr_2d is based on the consideration that we would never require tail processing for col_mid
(Ex.

// colMid & rowMid
) elements.
However, in certain cases of stride values, this region requires tail processing as well (Ex. stride = 13).

Describe the solution you'd like
I have already solved this issue in this branch of my fork, but we might be able to fix this in a more elegant way (perhaps without adding extra machine instructions in each iteration).

Additional context
This feature request is created for future reference (as I don't have much time to deal with this problem now), feel free to start a discussion and share your ideas.

@meshtag meshtag added bug Something isn't working enhancement New feature or request labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant