[DIP] Added BMP image encoding and decoding instead of opencv and Modify the image container test #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mread and imwrite
…mread and imwrite
FlagerLee
suggested changes
Aug 20, 2023
There was a problem hiding this comment.
Seems good with only one small problem. @zhanghb97 Any missing?
I'll run your code tomorrow.
FlagerLee
suggested changes
Aug 21, 2023
added 2 commits
August 31, 2023 05:30
FlagerLee
approved these changes
Aug 31, 2023
zhanghb97
requested changes
Sep 1, 2023
There was a problem hiding this comment.
We should keep the style uniform:
- unify filenames in imgcodecs
- use
.has suffix - remove "////////..." in the header of these reused files, which exceeds 80 column limitation.
A Design Point Discussion
Can we implement imread into the image constructor? What is the benefit of designing a separate imread function to build an image container object?
Error Report
Run DIP examples and get the following error:
terminate called after throwing an instance of 'std::logic_error'
what(): basic_string::_M_construct null not valid
Aborted (core dumped)
added 3 commits
September 4, 2023 06:28
…. in the header of these reused files, which exceeds 80 column limitation.
FlagerLee
suggested changes
Sep 7, 2023
…tion can pass parameters dynamically
FlagerLee
suggested changes
Sep 8, 2023
FlagerLee
approved these changes
Sep 8, 2023
qzylalala
pushed a commit
to qzylalala/buddy-mlir
that referenced
this pull request
Oct 30, 2023
* [DIP] Complete the constructor declaration of the image container Img class * [DIP] Adds definitions for constructor and member functions of the Img class * [DIP] Add a constructor to the Img class to implement Load image data from OpenCV Mat * [DIP] Modify the format of the code * [DIP] Added image encoding and decoding files, modified from opencv * [DIP] Added image encoding and decoding files, modified from opencv * [DIP] Modify the file format * [DIP] Added image encoding and decoding files, modified from opencv * [DIP] Added image encoding and decoding files, modified from opencv * [DIP] Added the main analysis file of bmp image (read header node, read image data) * [DIP] Added read and save functions for images * [DIP] Modify the comments of the read and save functions for images * [tests] Add a test image for the image container TestGrayImage.bmp * [DIP] Add a data pointer to the img class to access image data * [tests] Add move constructor test and copy constructor test * [examples] Add examples of test images YuTu.bmp * [examples][DIPDialect] replace opencv's imread and imwrite with our imread and imwrite * [examples][DIPDialect] replace opencv's imread and imwrite with our imread and imwrite * [examples][DIPDialect] Add the namespace dip to the Img class * [examples][DIP] Add the namespace dip to the Img class * [DIP] Example Modify the step setting * [DIP] Delete the definition of a move construct * [DIP] Delete some comments * [DIP] Modify the comments of the file * [DIP] Modify the grfmt_bmp.hpp file format * [DIP] Modify the bmp image 32-bit RGB image to grayscale image conversion function * [DIP] Img container doesn't need dip namespace * [DIP] _type should be placed after rows and cols to match initialize order. * [DIP] Modify the channels() function definition * [DIP] if image decoder doesn't exist throw an error. * [examples] Test against the old opencv * [DIP] Remove '_' before variable name * [DIP] add move constructor * [DIP] remove the data member variable from the Img container, replacing it with getData() * [DIP] Remove '_' after function name * [DIP] unify filenames in imgcodecs,use .h as suffix,remove ////////... in the header of these reused files, which exceeds 80 column limitation. * [DIP][examples] Remove the type definition in replenishment * [DIP] Delete the channels member variable of the Img class * [DIP] Modify the channels() function of the Img class * [DIP] Modify the constructor of the Img class so that the imread function can pass parameters dynamically * [DIP] Modify the Img constructor, replacing it with MemRef --------- Co-authored-by: Guan-schoolmate <[email protected]>
ShiHaoGao
pushed a commit
to ShiHaoGao/buddy-mlir
that referenced
this pull request
Oct 18, 2024
* [DIP] Complete the constructor declaration of the image container Img class * [DIP] Adds definitions for constructor and member functions of the Img class * [DIP] Add a constructor to the Img class to implement Load image data from OpenCV Mat * [DIP] Modify the format of the code * [DIP] Added image encoding and decoding files, modified from opencv * [DIP] Added image encoding and decoding files, modified from opencv * [DIP] Modify the file format * [DIP] Added image encoding and decoding files, modified from opencv * [DIP] Added image encoding and decoding files, modified from opencv * [DIP] Added the main analysis file of bmp image (read header node, read image data) * [DIP] Added read and save functions for images * [DIP] Modify the comments of the read and save functions for images * [tests] Add a test image for the image container TestGrayImage.bmp * [DIP] Add a data pointer to the img class to access image data * [tests] Add move constructor test and copy constructor test * [examples] Add examples of test images YuTu.bmp * [examples][DIPDialect] replace opencv's imread and imwrite with our imread and imwrite * [examples][DIPDialect] replace opencv's imread and imwrite with our imread and imwrite * [examples][DIPDialect] Add the namespace dip to the Img class * [examples][DIP] Add the namespace dip to the Img class * [DIP] Example Modify the step setting * [DIP] Delete the definition of a move construct * [DIP] Delete some comments * [DIP] Modify the comments of the file * [DIP] Modify the grfmt_bmp.hpp file format * [DIP] Modify the bmp image 32-bit RGB image to grayscale image conversion function * [DIP] Img container doesn't need dip namespace * [DIP] _type should be placed after rows and cols to match initialize order. * [DIP] Modify the channels() function definition * [DIP] if image decoder doesn't exist throw an error. * [examples] Test against the old opencv * [DIP] Remove '_' before variable name * [DIP] add move constructor * [DIP] remove the data member variable from the Img container, replacing it with getData() * [DIP] Remove '_' after function name * [DIP] unify filenames in imgcodecs,use .h as suffix,remove ////////... in the header of these reused files, which exceeds 80 column limitation. * [DIP][examples] Remove the type definition in replenishment * [DIP] Delete the channels member variable of the Img class * [DIP] Modify the channels() function of the Img class * [DIP] Modify the constructor of the Img class so that the imread function can pass parameters dynamically * [DIP] Modify the Img constructor, replacing it with MemRef --------- Co-authored-by: Guan-schoolmate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DIP] Added BMP image encoding and decoding.
[tests] Modified tests for image containers, added tests for copy constructs and move constructs.
[examples] Test BMP images by modifying rotation and resize files and replace opencv's imread and imwrite with our imread and imwrite.