[cmake] fix one-step build #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In one-step build, llvm include directory will be prepended into include directories list, and this cause the IR backend using LLVM provided IntinsicImpl.inc file. This commit add `BEFORE` keyword into include_directories macro to force prepend buddy-mlir backend include directory. Signed-off-by: Avimitin <[email protected]>
|
Thanks for your thorough analysis of the issue and your experienced debugging skills orz~ I have verified the RVV examples that were not supported originally. I think this PR is ready to be merged now. @zhanghb97 |
ShiHaoGao
pushed a commit
to ShiHaoGao/buddy-mlir
that referenced
this pull request
Oct 18, 2024
In one-step build, llvm include directory will be prepended into include directories list, and this cause the IR backend using LLVM provided IntinsicImpl.inc file. This commit add `BEFORE` keyword into include_directories macro to force prepend buddy-mlir backend include directory. Signed-off-by: Avimitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one-step build, llvm include directory will be prepended into include directories list, and this cause the IR backend using LLVM provided IntinsicImpl.inc file. This commit add
BEFOREkeyword into include_directories macro to force prepend buddy-mlir backend include directory.Fixed #181