Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build system]fix build bug. #200

Closed
wants to merge 1 commit into from
Closed

[build system]fix build bug. #200

wants to merge 1 commit into from

Conversation

linuxlonelyeagle
Copy link
Member

  • Fixed a bug in the build process.
  • Changed some formatting.

@FlagerLee
Copy link
Contributor

ContainerTest.cpp L111 should also be changed?
Why removing BatchMatMulOptimization?

@xlinsist
Copy link
Collaborator

FYI: A latest landed PR about BatchMatMulOptimization pass #187 has problems in cmake configuration and should be solved by #199.

cc @EllisLambda

@FlagerLee
Copy link
Contributor

  1. BatchMatMul bug solved by [midend] Fix build failure of batchmatmul optimization. #199
  2. The role of 'overloading bracket operator test' in ContainerTest is unclear. I'll fix it after discussed with @zhanghb97 (probably by deleting this test).

@FlagerLee FlagerLee closed this Sep 11, 2023
@linuxlonelyeagle
Copy link
Member Author

Is it necessary to compile and generate two libs? I just asked him to compile it into a lib, which is consistent with the directory name where these two files are stored.
BatchMatMulOptimize.cpp is compiled together with MatMulOptimize.cpp to generate the MatMulOptimization. This doesn't look very elegant, but I'm just making some suggestions.

add_mlir_library(MatMulOptimization
  BatchMatMulOptimize.cpp
	MatMulOptimize.cpp
)

@FlagerLee
Copy link
Contributor

@xlinsist

@xlinsist
Copy link
Collaborator

Is it necessary to compile and generate two libs? I just asked him to compile it into a lib, which is consistent with the directory name where these two files are stored. BatchMatMulOptimize.cpp is compiled together with MatMulOptimize.cpp to generate the MatMulOptimization. This doesn't look very elegant, but I'm just making some suggestions.

add_mlir_library(MatMulOptimization
  BatchMatMulOptimize.cpp
	MatMulOptimize.cpp
)

Thanks for your suggestions! We are considering combining two optimizations into one pass since batch matmul is one special case of matmul, so this part may be subject to change in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants