Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to edit an existing Service #142

Open
10 tasks done
turnerrainer opened this issue Sep 13, 2023 · 2 comments · Fixed by #176, #189 or #194
Open
10 tasks done

Add functionality to edit an existing Service #142

turnerrainer opened this issue Sep 13, 2023 · 2 comments · Fixed by #176, #189 or #194
Labels

Comments

@turnerrainer
Copy link
Contributor

turnerrainer commented Sep 13, 2023

AS An Administrative User / Service Manager
I WANT TO be able to edit a service
SO THAT I can modify its endpoints or flow if needed

Acceptance Criteria

  • Only Inactive services can be edited
  • Ability to edit service name
  • Ability to edit service description
  • Ability to edit service endpoints
  • Ability to edit service flow
  • When creating or editing service endpoint or flow, they should be saved to the service module structure in services/endpoints and services/flows
GUI
  • Edit Button is only active when the service is in-active
  • Clicking on the edit service button directs to the service creation flow with the title Edit {SERVICE_NAME}
  • Save Draft Buttons Saves the endpoints and flows and calls Services/edit endpoint to save the endpoints with the new changes
DSL
  • Services/edit endpoint to edit the service by passing it the service id along with all the other service information (i.e name, description, etc..)
@turnerrainer turnerrainer converted this from a draft issue Sep 13, 2023
@turnerrainer turnerrainer self-assigned this Sep 13, 2023
@turnerrainer turnerrainer moved this to To Groom in Service Module Sep 13, 2023
@turnerrainer turnerrainer moved this to To Groom in Bürokratt Sprint Sep 13, 2023
@turnerrainer turnerrainer changed the title Edit an existing Service Add functionality to edit an existing Service Nov 24, 2023
@turnerrainer turnerrainer removed their assignment Nov 24, 2023
@rasmusei rasmusei removed the sprint 15 label Dec 1, 2023
@turnerrainer turnerrainer linked a pull request Jan 25, 2024 that will close this issue
@turnerrainer turnerrainer moved this from In Review to To Deploy in Bürokratt Sprint Jan 25, 2024
@varmoh varmoh moved this from To Deploy to Acceptance Testing in Bürokratt Sprint Jan 25, 2024
@ValterAro
Copy link
Contributor

Short summary: when trying to edit a service and going to the service flow page, then you can not view or delete the previously added flow steps.
Expected result: You should be able to see and delete the service flow steps.
Real result: nothing happens when you press view or delete on the step.
How to reproduce: login and go to https://admin.dev.buerokratt.ee/services/overview , then try to edit "naljateenus" for example. Then go to the service flow and press the edit or delete button for the step.
Pic

Image

@ValterAro ValterAro moved this from To Groom to AT Rejected in Service Module Jan 26, 2024
@ValterAro ValterAro moved this from Acceptance Testing to AT Rejected in Bürokratt Sprint Jan 26, 2024
@PaulaMerle PaulaMerle moved this from AT Rejected to In Progress in Bürokratt Sprint Jan 26, 2024
@PaulaMerle PaulaMerle moved this from AT Rejected to In Progress in Service Module Jan 26, 2024
@ValterAro ValterAro mentioned this issue Jan 30, 2024
12 tasks
@turnerrainer turnerrainer linked a pull request Jan 31, 2024 that will close this issue
@turnerrainer turnerrainer moved this from In Progress to In Review in Bürokratt Sprint Jan 31, 2024
@PaulaMerle PaulaMerle moved this from In Review to To Deploy in Bürokratt Sprint Feb 1, 2024
@PaulaMerle PaulaMerle moved this from In Progress to Acceptance Testing in Service Module Feb 1, 2024
@KlviG KlviG moved this from To Deploy to Acceptance Testing in Bürokratt Sprint Feb 2, 2024
@ValterAro
Copy link
Contributor

Seems to work as intended.

@ValterAro ValterAro moved this from Acceptance Testing to Done in Service Module Feb 2, 2024
@ValterAro ValterAro moved this from Acceptance Testing to Done in Bürokratt Sprint Feb 2, 2024
@baha-a baha-a removed their assignment Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: Done
9 participants