Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all MSW requests #153

Open
4 tasks
turnerrainer opened this issue Oct 25, 2023 · 3 comments · Fixed by #154
Open
4 tasks

Remove all MSW requests #153

turnerrainer opened this issue Oct 25, 2023 · 3 comments · Fixed by #154

Comments

@turnerrainer
Copy link
Contributor

turnerrainer commented Oct 25, 2023

AS A Product Owner
I WANT all of the MSW requests to be removed and replaced with Ruuter endpoints
SO THAT the all of the mock requests would be removed and the service could be fully functioning

Acceptance Criteria

@turnerrainer turnerrainer converted this from a draft issue Oct 25, 2023
@turnerrainer turnerrainer moved this from To Groom to Ready in Service Module Oct 25, 2023
@rasmusei rasmusei moved this from Ready to In Progress in Bürokratt Sprint Oct 27, 2023
@rasmusei rasmusei moved this from In Progress to Acceptance Testing in Bürokratt Sprint Oct 30, 2023
@rasmusei rasmusei linked a pull request Oct 31, 2023 that will close this issue
@PaulaMerle PaulaMerle moved this from Ready to Acceptance Testing in Service Module Nov 10, 2023
@PaulaMerle PaulaMerle assigned ValterAro and unassigned MarkoKull Nov 10, 2023
@ValterAro
Copy link
Contributor

BUG:
Short summary: The MSW request all seem to be removed when testing the service module, but request to
/priv1/sse/cs-get-all-active-chats throws a 406 error and the request to
/services/cs-get-user-profile-settings?userId=EE..... throws a 404 error.
Expected result: /priv1/sse/cs-get-all-active-chats and /services/cs-get-user-profile-settings?userId=EE..... answer the correct way.
Real result: The two request throw an error (406 and 404)
How to reproduce the bug: Go to https://admin.dev.buerokratt.ee/services/overview after logging in and use inspect to view the network requests

@ValterAro ValterAro assigned KasparMinn and unassigned ValterAro Nov 13, 2023
@ValterAro ValterAro moved this from Acceptance Testing to AT Rejected in Bürokratt Sprint Nov 13, 2023
@ValterAro ValterAro moved this from Acceptance Testing to AT Rejected in Service Module Nov 13, 2023
@turnerrainer
Copy link
Contributor Author

AT will be done by @1AhmedYasser

@turnerrainer turnerrainer moved this from AT Rejected to Acceptance Testing in Bürokratt Sprint Nov 24, 2023
@turnerrainer turnerrainer moved this from Acceptance Testing to In Progress in Bürokratt Sprint Nov 27, 2023
@1AhmedYasser
Copy link
Collaborator

@turnerrainer Looks good to me, only one thing i noticed that the NSW package is still there and its unused anymore, so i will remove it in my next PR

@turnerrainer turnerrainer moved this from In Progress to Done in Bürokratt Sprint Nov 27, 2023
@1AhmedYasser 1AhmedYasser removed their assignment Nov 28, 2023
@PaulaMerle PaulaMerle moved this from AT Rejected to Done in Service Module Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants