Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new state to the Service #191

Open
2 of 3 tasks
PaulaMerle opened this issue Jan 25, 2024 · 8 comments · Fixed by #214
Open
2 of 3 tasks

Add a new state to the Service #191

PaulaMerle opened this issue Jan 25, 2024 · 8 comments · Fixed by #214
Assignees
Labels

Comments

@PaulaMerle
Copy link
Contributor

PaulaMerle commented Jan 25, 2024

AS A Service Manager
I WANT TO have new state for the Service - READY
SO THAT it would represent the Services that are ready but not yet associated with an intent or not activated

Related to the task #41
Take into account #195

Acceptance criteria

  • new status named READY (valmis) created
  • status is visible in the table of Services in the landing page
  • Service state logic goes as follows draft <-> ready -> active <-> inactive -> draft.
@PaulaMerle PaulaMerle converted this from a draft issue Jan 25, 2024
@PaulaMerle PaulaMerle moved this to To Groom in Bürokratt Sprint Jan 25, 2024
@PaulaMerle PaulaMerle moved this from To Groom to Ready in Service Module Feb 26, 2024
@PaulaMerle PaulaMerle moved this from To Groom to Ready in Bürokratt Sprint Feb 26, 2024
@PaulaMerle PaulaMerle removed their assignment Feb 26, 2024
@turnerrainer turnerrainer linked a pull request Feb 28, 2024 that will close this issue
@turnerrainer turnerrainer moved this from Ready to Blocked in Bürokratt Sprint Feb 28, 2024
@1AhmedYasser
Copy link
Collaborator

1AhmedYasser commented Feb 28, 2024

blocked waiting for #196

@turnerrainer turnerrainer moved this from Blocked to In Review in Bürokratt Sprint Feb 29, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in Service Module Feb 29, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Bürokratt Sprint Feb 29, 2024
@PaulaMerle PaulaMerle moved this from Done to To Deploy in Bürokratt Sprint Feb 29, 2024
@PaulaMerle PaulaMerle moved this from Done to Acceptance Testing in Service Module Feb 29, 2024
@varmoh varmoh moved this from To Deploy to Acceptance Testing in Bürokratt Sprint Feb 29, 2024
@ValterAro
Copy link
Contributor

Short summary:
Something seems to have broken the ability to see the list of services. Can not see the change until this is fixed.
Pic:

Image

@ValterAro ValterAro moved this from Acceptance Testing to AT Rejected in Bürokratt Sprint Mar 4, 2024
@ValterAro ValterAro moved this from Acceptance Testing to AT Rejected in Service Module Mar 4, 2024
@1AhmedYasser
Copy link
Collaborator

@ValterAro Working on local, checked it on dev environment with Varmo, and found the problem in services_db, will work on a fix for it with Alar on dev environment

@1AhmedYasser
Copy link
Collaborator

@ValterAro its now fixed, please recheck again

@PaulaMerle PaulaMerle moved this from AT Rejected to Acceptance Testing in Bürokratt Sprint Mar 5, 2024
@PaulaMerle PaulaMerle moved this from AT Rejected to Acceptance Testing in Service Module Mar 5, 2024
@ValterAro
Copy link
Contributor

The last AC can not be currently tested as per this comment (#196 (comment)). Setting this currently blocked until an intent can be turned into a serivce.

@ValterAro ValterAro moved this from Acceptance Testing to Blocked in Bürokratt Sprint Mar 5, 2024
@ValterAro ValterAro moved this from Acceptance Testing to Blocked in Service Module Mar 5, 2024
@turnerrainer turnerrainer reopened this Mar 11, 2024
@turnerrainer turnerrainer moved this from Blocked to Acceptance Testing in Bürokratt Sprint Mar 18, 2024
@PaulaMerle
Copy link
Contributor Author

@1AhmedYasser
State Ready has been created.
Cannot test the third AC about the state change logic, since currently not yet possible to complete the process of connecting service to an intent (after connecting the process will remain "pending").

@ValterAro
Copy link
Contributor

ValterAro commented Apr 1, 2024

Current state:
Short summary: When trying to add an intent to a service in the Service module then I can request to add an intent to a service, but I can not add a service to an intent or accept the request.
Waiting for the issue (https://github.com/orgs/buerokratt/projects/47/views/35?pane=issue&itemId=49548120) until this can be tested
Expected result: You should be able to connect the service with an intent
Current result: There is no way to accept the request to connect the intent with a service from the training module side.
How to reproduce: Go to https://admin.dev.buerokratt.ee/training/training/intents and create a new intent that you plan to connect with a service. Then Go to service module and create a service and then change the state from draft to ready and then press again to connect to a service. Then select the created intent to connect. Then go to Training module side and try to accept the request to connect the intent to the service.
Pic:

Image

Image

@ValterAro
Copy link
Contributor

The latest deploy seems to have fixed it. It is working as intended.

@ValterAro ValterAro moved this from Blocked to Done in Service Module Apr 4, 2024
@ValterAro ValterAro moved this from Acceptance Testing to Done in Bürokratt Sprint Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants