Refactor all Service Module's Postgres queries to replace DELETE queries with INSERT and SELECT
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1AhmedYasser
suggested changes
May 18, 2024
| @@ -1,6 +1,2 @@ | |||
| INSERT INTO services (name, description, service_id, ruuter_type, is_common, structure) | |||
| VALUES (:name, :description, :service_id, :ruuter_type::ruuter_request_type, :is_common, :structure::json) | |||
| ON CONFLICT (service_id) DO UPDATE | |||
There was a problem hiding this comment.
This can have conflicts as service id is generated, and may conflict
There was a problem hiding this comment.
The service_id is not auto-generated, it's defined as TEXT, plus, I've removed the unique constraint on it here, As a result, we can now insert multiple service_id with the same value.
1AhmedYasser
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
DELETEqueries withINSERTandSELECT#278