You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm trying to migrate from separate actions you provided earlier into this all-in-one action.
But I have spotted an issue with our 2 buf modules. We have proto/public and proto/internal folders so I have 2 Github actions. See example of action yaml below. We trigger that action only when there is a change inside specific folder.
Reason we have 2 separate actions is breaking check. For public, we cannot do breaking change (except rare case) but for internal, we can. As we deploy all together (not best approach, but for now it speeds up development), so we are OK with small risk.
However, your action in the first run created 2 comments with same wording. So it is not possible to differentiate between them.
And during second round, action modified just 1 comment, and the second was left unchanged.
Do you plan to support multiple buf-action runs within same PR?
Thank you
Same file we have twice, once with proto/public and second with proto/internal.
Hey @arxeiss, the action doesn't currently support multiple runs updating the comment. I'll have a look at adding a fix to better support this usecase. For now you can disable comments with pr_comment: false or trigger only certain proto files or only run checks in certain directories avoiding duplicates.
@arxeiss would you be able to validate the solution in #52 solves your use case? You may use that action as: - uses: bufbuild/buf-action@ed/multiComments to test.
Hello,
I'm trying to migrate from separate actions you provided earlier into this all-in-one action.
But I have spotted an issue with our 2 buf modules. We have
proto/public
andproto/internal
folders so I have 2 Github actions. See example of action yaml below. We trigger that action only when there is a change inside specific folder.Reason we have 2 separate actions is breaking check. For public, we cannot do breaking change (except rare case) but for internal, we can. As we deploy all together (not best approach, but for now it speeds up development), so we are OK with small risk.
However, your action in the first run created 2 comments with same wording. So it is not possible to differentiate between them.
And during second round, action modified just 1 comment, and the second was left unchanged.
Do you plan to support multiple buf-action runs within same PR?
Thank you
Same file we have twice, once with
proto/public
and second withproto/internal
.The text was updated successfully, but these errors were encountered: