Disable PR comment by default from forks #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forked PRs can fail to access the secrets for the repository. This can fail on trying to comment the results from CI on the PR. Disable comments for all forked by default.
This comment has been minimized.
This comment has been minimized.
doriable
approved these changes
Aug 20, 2024
Merged
emcfarlane
added a commit
that referenced
this pull request
Aug 20, 2024
Releases the changes in #64 to fix failures in CI for contributors PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked PRs can fail to access the secrets for the repository. This can fail on trying to comment the results from CI on the PR. Disable comments for all forked by default.
Tested here on a forked emcfarlane/releases#14 and unforked emcfarlane/releases#15 change. The update before reference buf-action@main, then updating to buf-action@ed/disableForkComment the forked comment now disables the comment, whilst the unforked still comments.