Prevent the error when explicitly specifying default buf gen temlate file path #199
Conversation
|
|
| @@ -50,8 +50,10 @@ abstract class GenerateTask : DefaultTask() { | |||
| check(specifiedTemplateFile != null) { | |||
| "Specified templateFileLocation does not exist." | |||
| } | |||
| check(defaultTemplateFile == null) { | |||
| "Buf gen template file specified in the project directory as well as with templateFileLocation; pick one." | |||
| if (specifiedTemplateFile != defaultTemplateFile) { | |||
There was a problem hiding this comment.
You can replace the nested if with:
check(defaultTemplateFile == null || specifiedTemplateFile == defaultTemplateFile)
| } | ||
|
|
||
| buf { | ||
| generate { |
There was a problem hiding this comment.
To show that in general it is o.k. to repeat defaults, you could add:
configFileLocation = rootProject.file("./buf.yaml")
and add a single buf.yaml file in this directory like:
version: v1
| } | ||
|
|
||
| buf { | ||
| generate { |
There was a problem hiding this comment.
To show that in general it is o.k. to repeat defaults, you could add:
configFileLocation = rootProject.file("./buf.yaml")
and add a single buf.yaml file in this directory like:
version: v1
|
@un1024 Please let me know in the next day or so if you still want to be involved with this PR, otherwise I will go ahead and push my change to the branch and get the PR merged. |
|
@drice-buf Sorry, I've forgotten this Pull Request and am late... 🙇 I have fixed and pushed for your comments. |
|
@un1024 thanks for the PR and for bringing it up to date quickly. |
Backgroud: I encountered the following error.
But I have just one template file
{rootDir}/buf.gen.yaml.I didn't understand the reason for the error until I read the source code.
I think it's natural to want to specify the file path explicitly.
Therefore how about making this trivial fix to prevent confusion?
Thanks.