From c6602469519700a4511d23955632a8b63b51fcbf Mon Sep 17 00:00:00 2001 From: Oliver Sun <73540835+oliversun9@users.noreply.github.com> Date: Thu, 26 Oct 2023 18:29:29 -0400 Subject: [PATCH] Use make lint in CI instead of golangci-lint action (#70) Run `make lint` in CI instead of using the action to make sure CI is consistent with running `make lint` locally. --- .github/workflows/ci.yaml | 9 +-------- Makefile | 2 +- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 07f2672..8ec98fc 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -34,11 +34,4 @@ jobs: # Often, lint guidelines depend on the Go version. To prevent # conflicting guidance, run only on the most recent supported version. if: matrix.go-version == 'stable' - uses: golangci/golangci-lint-action@v3 - with: - skip-pkg-cache: true - only-new-issues: true - args: > - --modules-download-mode=readonly - --timeout=3m0s - ./... + run: make lint diff --git a/Makefile b/Makefile index da1af02..850f3be 100644 --- a/Makefile +++ b/Makefile @@ -38,7 +38,7 @@ lint: lint-proto lint-go ## Lint code and protos .PHONY: lint-go lint-go: $(BIN)/golangci-lint - $(BIN)/golangci-lint run ./... + $(BIN)/golangci-lint run --modules-download-mode=readonly --timeout=3m0s ./... .PHONY: lint-proto lint-proto: $(BIN)/buf