Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buf CLI group ID #111

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix buf CLI group ID #111

merged 1 commit into from
Mar 7, 2024

Conversation

pkwarren
Copy link
Member

@pkwarren pkwarren commented Mar 7, 2024

No description provided.

@pkwarren pkwarren requested review from jhump and drice-buf March 7, 2024 14:21
@@ -11,7 +11,7 @@ protobuf = "3.25.3"

[libraries]
assertj = { module = "org.assertj:assertj-core", version.ref = "assertj" }
buf = { module = "buf.build:buf", version.ref = "buf" }
buf = { module = "build.buf:buf", version.ref = "buf" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had added this here just so dependabot could keep buf CLI updated for us, however it isn't used as a dependency (since this is just the .pom artifact). This is where we use the version that we want to keep updated:

buf("build.buf:buf:${libs.versions.buf.get()}:${osdetector.classifier}@exe")

@pkwarren pkwarren merged commit a8f9a60 into main Mar 7, 2024
5 checks passed
@pkwarren pkwarren deleted the pkw/fix-dependency-name branch March 7, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants