Improve theme definition #58
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
themes
branch
3 times, most recently
from
6ae064e to
600bddf
Compare
|
I'm still not quite happy with where this goes. Ideally, I would like to set a primary and seconday accent color, and the theme should generate all colors necessary. This will probably be the focus of a future PR |
bugadani
force-pushed
the
themes
branch
8 times, most recently
from
309db8a to
36909a0
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements DefaultTheme in a bit more flexible way, and allows extending the theme with additional color schemes.
Closes #55 and maybe others
Remaining:
StateA, StateB { ... })After impl, decide if helper macros should/could be deduplicated.
Investigate how to allow more color options in RGB color schemes.
Define styles required to close #23 and #36, #37