💄 Sticky TopBar #439
Merged
💄 Sticky TopBar #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks broken. Also I would prefer to have the header go out of the way while scrolling down and get into the frame when scrolling up. This keeps the application useable on high zoom, which is nice for accessebility. |
|
@anuejn I cannot reproduce this :( Did you do something special? hmm... I am not a huge fan of hiding the top bar when scrolling up and I really think there is enough space even on very high zoom. |
phlmn
force-pushed
the
phlmn/sticky-header
branch
from
24642e9 to
9dc9976
Compare
closes #359
phlmn
force-pushed
the
phlmn/sticky-header
branch
from
9dc9976 to
8248698
Compare
anuejn
approved these changes
Jun 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #359