Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to golang.org/x/sys/windows #179

Closed
2 tasks done
twpayne opened this issue Mar 18, 2024 · 2 comments · Fixed by #187
Closed
2 tasks done

Switch to golang.org/x/sys/windows #179

twpayne opened this issue Mar 18, 2024 · 2 comments · Fixed by #187

Comments

@twpayne
Copy link
Contributor

twpayne commented Mar 18, 2024

Describe the new feature or change suggestion

Firstly, thank you for this project!

Currently go.bug.st/serial has its own generated Windows syscalls in syscall_windows.go and zsyscall_windows.go. I recently opened a PR for golang.org/x/sys that adds the necessary calls: https://go-review.googlesource.com/c/sys/+/572295.

Once this is merged and released then go.bug.st/serial can switch to a more recent version of golang.org/x/sys and remove its generated code. I'm happy to open a PR to do this when the time comes.

Additional context

#149 makes a similar change. Can #149 be merged too?

Issue checklist

  • I searched for previous requests in the issue tracker
  • My request contains all necessary details
@twpayne
Copy link
Contributor Author

twpayne commented May 20, 2024

Closing due to inactivity.

@twpayne twpayne closed this as completed May 20, 2024
@cmaglie cmaglie reopened this Jun 24, 2024
@cmaglie
Copy link
Member

cmaglie commented Jun 24, 2024

@twpayne I'm sorry for the long delay in replying, unfortunately, I run this project in my free time, so issues may take very long to process.

I'll reopen this issue since it's a valid and valuable concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants