Add rules_oci #7568
Merged
Add rules_oci #7568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/init-rules-oci
branch
from
5ec358c to
4cdaeab
Compare
sluongng
force-pushed
the
sluongng/init-rules-oci
branch
2 times, most recently
from
e27a7cc to
e2be71b
Compare
sluongng
force-pushed
the
sluongng/init-rules-oci
branch
2 times, most recently
from
ae1c79d to
eb69d65
Compare
sluongng
force-pushed
the
sluongng/init-rules-oci
branch
from
eb69d65 to
27ca19a
Compare
fmeum
approved these changes
Sep 28, 2024
sluongng
commented
Sep 30, 2024
| @@ -130,3 +132,27 @@ container_image( | |||
| tags = ["manual"], | |||
| visibility = ["//visibility:public"], | |||
| ) | |||
|
|
|||
| # TODO(sluongng): Verify the layering of the image. | |||
There was a problem hiding this comment.
Worth noting: I am aware that the current pkg_tar setup is wrong.
- It does not pull in the much-needed runfiles of the go binaries
- There are also some layout changes on the final oci image vs the old image that we should address.
Since this PR is already fairly sized and does not break anything, I will be merging this as-is. A subsequent PR will be sent to correct the rules_pkg usage and oci image layout.
sluongng
added a commit
that referenced
this pull request
Sep 30, 2024
This reverts commit 5430f7a. Break current release flow.
sluongng
added a commit
that referenced
this pull request
Sep 30, 2024
sluongng
added a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rules_oci and build an example image with it to test it's compatibility with our current rules_docker usage.