You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe a lot of complexity could be removed by swapping config parsing from a manually process with yaml-rust to object deserialization with serde with it's derive feature and a supporting yaml deserializer.
The Intermediate types could be removed as the deserializer understands optional parameters. To handle defaults, the attributes on config can be made private and getters can be implemented that access self and unwrap to a default if they were not set. The mode "serial" or "parallel" can be mapped properly via the derive attribute macros on enums.
Heads up: @ChristopherJMiller pls make sure you're on updated 3.x branch when you start working on this, I've merged quite a few infrastructure updates in last few days 😬
I believe a lot of complexity could be removed by swapping config parsing from a manually process with
yaml-rust
to object deserialization with serde with it's derive feature and a supporting yaml deserializer.The Intermediate types could be removed as the deserializer understands optional parameters. To handle defaults, the attributes on config can be made private and getters can be implemented that access
self
and unwrap to a default if they were not set. The mode "serial" or "parallel" can be mapped properly via the derive attribute macros on enums.This could also ease the work involved with #265
Thoughts?
The text was updated successfully, but these errors were encountered: