Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tracing crate instead of println #283

Open
akshob opened this issue Sep 27, 2022 · 1 comment
Open

Use tracing crate instead of println #283

akshob opened this issue Sep 27, 2022 · 1 comment

Comments

@akshob
Copy link

akshob commented Sep 27, 2022

Currently logs are printed on the command line via println. Replacing all the logs with tracing::info! and tracing::debug! would give flexibility with where we show the output - terminal, log file, or upload to a telemetry service using open telemetry.
It is also possible to pipe the stdout and stderr of rysnc and gradlew, so we can choose to filter it out (without relevant command line argument).

Thoughts?

@artem-zinnatullin
Copy link
Contributor

Currently all the logs that Mainframer prints are expected to be seen by user

Perhaps we could add --quiet flag that might rely on something like tracing to suppress the output.

With regards to logging into a log file or uploads to telemetry servers — this is not needed as Mainfraimer is a CLI tool for users, not a backend service or something like this I'd say :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants