Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel Duration support in config spec #284

Open
ChristopherJMiller opened this issue Oct 5, 2022 · 0 comments
Open

Parallel Duration support in config spec #284

ChristopherJMiller opened this issue Oct 5, 2022 · 0 comments

Comments

@ChristopherJMiller
Copy link
Contributor

The config spec needs to be updated to define the parallel pull's duration.

Internally, mainframer supported this functionality with PullMode::Parallel(Duration), but with the introduction of #282 this had to be removed due to the inability to serialize/deserialize this enum type in yaml.

To keep compatibility with previous configs in addition to supporting this functionality, I propose an extension to the Pull object itself, adding an optional duration parameter that is only used if pull is defined for the pull mode. If pull is defined without a duration set, we can default to the usual 500ms interval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant