Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

buildium/css-standards

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

14 Commits
 
 
 
 

Repository files navigation

Buildium CSS standards

Our approach to writing simple, scalable CSS

Table of Contents

  1. Mission and goals
  2. Our tools
  3. Organizing stylesheets
  4. Common variables
  5. Naming
  6. Positioning and layout
  7. Consistent order of properties
  8. Specificity
  9. Shorthand vs. longhand
  10. Formatting
  11. Styleguide
  12. Resources and further reading

Mission and goals

simplicity

Something simple has a clear purpose and direction, while something easy is that which is near at hand and familiar. Using ID's as CSS selectors is easy, but not necessarily simple, because in the long run it will create complicated specificity issues.

find styles that exist or create new styles

The names of classes should reflect the component they are providing styles for so that a developer can look some markup and have a reasonable guess where to look for a style (or what to search for). In addition, the file structure of our components and stylesheets should make finding relevant styles quick.

create or modify pages

By following the guidelines here, developers should be able to create new components and styles without worrying about conflicting with existing styles.

with confidence

One of the biggest frustrations with tangled CSS is that it’s nearly impossible to know when a local change has an unwanted side-effect. Developers can prevent these headaches by sticking to stricter conventions.

Our Tools

Our front-end code base at Buildium consists of a series of individual Angular.js applications, each serving a different part of our product. Each of these apps consists of even smaller components (directives, views, and controllers). And, we store common components that are used across multiple parts of the product in a directory called 'buildium-base'.

To help organize and optimize our stylesheets, we use LESS.

Organizing stylesheets

A typical Angular component directory (a search bar directive, in this case) will look like this:

buildium-base/components/search

-search.html           //template
-search.js             //directive
-search.less           //styles
-search.test.js        //unit test

As you can see, this component contains its own stylesheet. This is imported into a file in the root components directory called main.less.

components/main.less is then imported into a styles directory within buildium-base. This style directory contains common elements like mixins, variables, and other tools that we'd like access to when writing component specific styles. This approach keeps the component specific stylesheets lean, and also reserves a special place to write styles that can be used globally.

##Common Variables

Use common mixins for visual behaviors that are likely repeated throughout the site such as colors, box-shadow, border-radius, etc.

All colors should be defined as common variables, and we store them in buildium-base/styles/variables/colors.less.

##Naming

We use the Block Element Modifier (BEM) naming convention. BEM-style names are, in general, very descriptive. They also provide a way of indicating hierarchy without the side-effects of nesting classes and causing specificity battles. Finally, BEM is very conducive to creating a component-based UI (which we strive for in our Angular-based code). Class names in BEM follow this pattern: block__element--modifier.

Always try to make class names meaningful -- "large" is better than 600, "primary" is better than blue.

//less

.search__entity-list {
   .list-reset;
}

.search__entity-list-item {
   padding: 10px 5px 10px 38px;
   background-image: url(/Manager/static-images/search-sprite.png);
   background-repeat: no-repeat;
   font-size: 12px;
}

.search__entity-list-item--active {
   background-color: @focusHighlight;
}
//view

<ul class="search__entity-list">
  <li class="search__entity-list-item  
    search__entity-list-item--{{item.category}}"
    ng-repeat="item in entity.item"
    ng-class="{ 'search__entity-list-item--active': item === search.activeItem }"
    ng-mouseover="search.activeItem = item">
</ul>

It’s better to separate out what is essential to all form columns (positioning and gutters) and what is a specific modifier (width).

//Avoid - does too many things

.formColumnSmall {
    float: left;
    margin: 0 @grid-gutter-width / 2;
    width: 90px;
}

//Instead, seperate it out...

.form__column {
   float: left;
   margin: 0 @grid-gutter-width / 2;
}

.form__column--small {
   width: 90px;
}

.form__column--default {
   width: 202.5px;
}

Positioning/Layout

Separate positioning and layout from reuseable components. We use a grid system for positioning, making things predictable, and preventing a specific component's styles from affecting others.

Lay out your pages using rows and columns. For forms (the most common type of page in our application), we use a .form__column class with appropriate modifiers for width:

<div class="row">
    <div class="form__column form__column--default" bd-form-element>
        <label class="form__label" for="required">Required</label>
        <input class="form-element form-element--default" name="required" id="required" required ng-model="vm.formModel.required" />
    </div>
</div>

<div class="form__vertical-spacer form__vertical-spacer--medium"></div>

You'll notice we handle vertical spacing using specific spacing elements.

Individual controls

Individual blocks should not have positioning information or external margin/padding because this makes components difficult to adapt to varying circumstances. For example, if an input element includes a bottom margin, we are forced to create more and more overrides in cases where we want a different size gutter between elements.

Instead, we strive to write components that take up the full size of their container (100% width) and do not have external margins or padding.

Consistent order of properties

By keeping a consistent order of properties within a class, it’s easier to quickly read/write an existing class. It takes away the need to search through the entire class to see if a given property is set.

When writing a class, group different CSS properties together and place them in the following order (credit to Mark Otto @mdo):

  • Positioning
  • Display and box mode
  • Typographic
  • Visual
.declaration-order {
    /* Positioning */
    position: absolute;
    top: 0;
    right: 0;
    bottom: 0;
    left: 0;
    z-index: 100;

    /* Display and box model */
    display: block;
    float: right;
    width: 100px;
    height: 100px;
    padding: 5px;

    /* Typography */
    font: normal 13px "Helvetica Neue", sans-serif;
    line-height: 1.5;
    color: @offBlack;
    text-align: center;

    /* Visual */
    background-color: @lightBlue;
    border: 1px solid @green;
    border-radius: 3px;
}

##Specificity

  • Use classes. No ID's!
  • Elements: only use them for resetting or normalizing styles between browsers.
  • If using JS to access a class, prefix it with js-, i.e. js-my-selector and use it only for JS
  • Try to only override a property at most 1 time:
.my-class {
	font-size: 12px;
	text-align: center;
}

/** this class only overrides a single property. "text-align" remains the same **/
.my-class--left-text {
	text-align: left;
}

Shorthand vs. longhand

  • Define colors in their own less files using upper-case, long-hand Hex format. For example #FFFFFF;
  • Define all sizes in properties that take 4 arguments: border: 0 0 0 1px vs border-left: 1px;
  • Use more specific properties when overriding classes, if possible: border-left: 1px vs border: 0 0 0 1px;

Formatting

  • Curly braces should start on the same line as the class name, with one space between.
  • Each property should have its own line, with semi-colons, and one space between.
  • Avoid using 0px, 0em, etc.; instead use 0.
  • Each class should have a line between.
  • Avoid nesting classes, if possible.
  • Don’t use vendor-specific prefixes. We run the styles through autoprefixer which will automatically insert prefixes when needed.

##Common helpers

By separating some common behaviors - like those listed below - we can better keep track of variations within the app. This should keep the visual appearance and behavior of different parts of the site (text shadows, for example) more coherent.

These should be in common helpers:

  • positioning
  • transitions
  • rounding edges
  • shadows
  • common fonts, i.e. for accounting

These are common helpers, but an element might have them. As a general rule, you can use a few, but if we are adding more than 3 helpers, make a class.

Styleguide

Documentation is great, but writing and reading it should be convenient and located near the code itself.

We use kss-node to generate docs from comments in styles.

  • Spec is https://github.com/kss-node/kss/blob/spec/SPEC.md
  • Comments should have a title and a description.
  • Separate markup will be generated for each modifier class (.selected, in the example below the description text), using the Markup field.
  • We’ve added a DocUrl field to the spec, that links to our living styleguide.
  • The Styleguide variable at the end will put your comments in the right place.

Example:

/*
Tabs

Tabs are used to segment content for a single entity into logical groups.

.selected - Indicates tab is selected

Markup:
<nav id="tabbedNav">
   <ul>
       <li><a href>Summary</a></li>
       <li class="{{modifier_class}}"><a href>Application</a></li>
       <li><a href>Screening</a></li>
       <li><a href>Fee</a></li>
   </ul>
</nav>

DocUrl:
http://styleguide.buildium.com/dm01-1400-tabs/

Styleguide 3.1
*/

Resources and further reading

CSS and HTML styleguide by Mark Otto.

MindBEMding – getting your head ’round BEM syntax

BEM 101

About

No description, website, or topics provided.

Resources

License

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published