Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Integrate Buildium eslint #2

Open
mndewitt opened this issue Feb 3, 2016 · 2 comments
Open

Integrate Buildium eslint #2

mndewitt opened this issue Feb 3, 2016 · 2 comments

Comments

@mndewitt
Copy link
Contributor

mndewitt commented Feb 3, 2016

It would be great to run the Buildium eslint config on these template to make sure they pass. I got as far as:

-Adding gulp
-Adding eslint

The main issue is that the EJS syntax in the templates causes eslint to fail. I'm wondering if there is a way around this. There is also some work to do to integrate the Buildium eslint config into this project.

Looking for help with part or all of the following tasks:

-Add a build tool (we think npm scripts would work well for this) and add eslint
-Integrate the buildium eslint plugin and config to the project
-Automating the checks in a git hook :)

@jbalboni
Copy link
Contributor

jbalboni commented Feb 4, 2016

For other OSS projects, we've so far used npm scripts instead of gulp or grunt. That might be an option if whatever "build" we need to do stays simple.

@mndewitt
Copy link
Contributor Author

mndewitt commented Feb 4, 2016

Makes sense, gulp would be overkill.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants