You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
When a date is selected, with default settings, the onChange function is called with a value that is misleading.
The date value contains the current time like so - 2018-07-31T21:16:25Z. Instead I would expect a value of something like 2018-07-31T00:00:00Z or 2018-07-31T00:00:00-07:00 (moment("20111031", "YYYYMMDD")).
The reason why this is problematic, is that if a user clicks on the date value at the beginning of the day and then clicks that same date at a different time of the day, the date value will be different. Which could lead to unintended results.
I think it makes sense to zero out the dates, or use the results from moment().
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When a date is selected, with default settings, the onChange function is called with a value that is misleading.
The date value contains the current time like so -
2018-07-31T21:16:25Z
. Instead I would expect a value of something like2018-07-31T00:00:00Z
or2018-07-31T00:00:00-07:00
(moment("20111031", "YYYYMMDD")
).The reason why this is problematic, is that if a user clicks on the date value at the beginning of the day and then clicks that same date at a different time of the day, the date value will be different. Which could lead to unintended results.
I think it makes sense to zero out the dates, or use the results from
moment()
.The text was updated successfully, but these errors were encountered: