Add whitelist and blacklist support. #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why in the tests load is passed an empty class - the code seems to read config successfully in real situations - though I'm not that up on buildout's internals, so there's probably a better way to get access to the config... |
|
A simple solution to the test errors is to add the following as a method in the Not sure if you'd prefer another way of handling it? (perhaps implementing returning a test config to run through tests of the new features?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #14. Explanation of how it is designed to work is in the updated README.
I've opted to set it up so that the presence of any entries in the whitelists, or the location or basename being on a blacklist, is a deny.
After that, the location or basename being on a whitelist 're-allows' that wheel.
I think this is the most flexible approach to allowing filtering against locations and packages, but feel free to disagree, or make any other suggestions on improvements to the code.