Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skopeo as a library to load/push images #70

Open
dr-housemd opened this issue Jul 10, 2024 · 5 comments · May be fixed by #90
Open

Skopeo as a library to load/push images #70

dr-housemd opened this issue Jul 10, 2024 · 5 comments · May be fixed by #90
Milestone

Comments

@dr-housemd
Copy link
Contributor

Currently, we os.Exec("nix run nixpkgs#skopeo...") to load/push image. We should use the library instead. Reason being that it'll save the user the time to download & build skopeo on the fly.

@dr-housemd dr-housemd added the good first issue Good for newcomers label Jul 10, 2024
@BalaadityaPatanjali
Copy link
Contributor

BalaadityaPatanjali commented Jul 10, 2024

I would like to work on this !
Can you guide a little on this one ? Where do i get started from ?

@dr-housemd
Copy link
Contributor Author

@BalaadityaPatanjali So Skopeo has a bunch of commands here. We do not need all of them or all the features as bsf is opinionated .

You can find that we use Skopeo copy a lot in this file.

We can then inspect the code in skopeo cmd/copy and see which pkg they use and use it in bsf directly. Please feel free to ping us on Discord if you're stuck/feel lost.

@BalaadityaPatanjali
Copy link
Contributor

@BalaadityaPatanjali So Skopeo has a bunch of commands here. We do not need all of them or all the features as bsf is opinionated .

You can find that we use Skopeo copy a lot in this file.

We can then inspect the code in skopeo cmd/copy and see which pkg they use and use it in bsf directly. Please feel free to ping us on Discord if you're stuck/feel lost.

I'll try that and get working on it !

@dr-housemd dr-housemd added this to the v0.3.0 milestone Jul 13, 2024
@dr-housemd
Copy link
Contributor Author

@BalaadityaPatanjali let us know if you need any help and feel free to ping us on Discord!

@BalaadityaPatanjali
Copy link
Contributor

@BalaadityaPatanjali let us know if you need any help and feel free to ping us on Discord!

Thankyou ! I have addressed the problems i am facing on discord.

@dr-housemd dr-housemd removed the good first issue Good for newcomers label Aug 5, 2024
@dr-housemd dr-housemd modified the milestones: v0.3.0, v0.5.0 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants