Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VWAP indicator is wrong #262

Open
Datamined opened this issue Aug 12, 2021 · 3 comments · May be fixed by #285
Open

VWAP indicator is wrong #262

Datamined opened this issue Aug 12, 2021 · 3 comments · May be fixed by #285
Labels

Comments

@Datamined
Copy link

In accordance with the definition of VWAP that you provide in the documentation VWAP should be calculated using cumulative volume, which is calculated from the start of the trading session (when we talk about relatively small timeframes, at least less than a day). There is no any rolling window in the definition, all volume since the day start (or other anchor) should be taken into account.

In other words, for each index this "rolling window size" should be equal to the index.
For instance, see the implementation here.

@zwangz
Copy link

zwangz commented Aug 22, 2021

I second this. Just tried the library and VWAP was first indicator I used, immediately realised something was not right....

@epicshardz
Copy link

I third this issue. This indicator is completely wrong.

@lit26 lit26 added the bug label Dec 22, 2021
@lit26 lit26 linked a pull request Feb 23, 2022 that will close this issue
@EaglePPP
Copy link

EaglePPP commented Mar 20, 2024

  1. reset period should be added
  2. 1 bar of the reset period does not use volume to calculate, just simple hcl3
    I m actually here to ask what is the window args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants