From eeefd8d272941126c7e23f2511851000c3d738fa Mon Sep 17 00:00:00 2001 From: Jeremy Green Date: Fri, 18 Oct 2024 14:27:47 -0500 Subject: [PATCH 1/2] Imporoved Heroku Detection Heroku recently made some changes to how they set the `PATH` ENV var and now it no longer includes `/app/.heroku/` so our previous detection method is broken. Now we'll look for `ENV['HEROKU_APP_NAME']`. --- bullet_train/lib/bullet_train.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bullet_train/lib/bullet_train.rb b/bullet_train/lib/bullet_train.rb index 063016b09..a2e95dc98 100644 --- a/bullet_train/lib/bullet_train.rb +++ b/bullet_train/lib/bullet_train.rb @@ -73,7 +73,7 @@ def default_url_options_from_base_url end def heroku? - ENV["PATH"]&.include?("/app/.heroku/") + ENV['HEROKU_APP_NAME'].present? end def inbound_email_enabled? From bbfb46f2fec4ed5747a6e7b5164e2a27e6380f43 Mon Sep 17 00:00:00 2001 From: Jeremy Green Date: Fri, 18 Oct 2024 14:33:51 -0500 Subject: [PATCH 2/2] linter --- bullet_train/lib/bullet_train.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bullet_train/lib/bullet_train.rb b/bullet_train/lib/bullet_train.rb index a2e95dc98..1273d1ef8 100644 --- a/bullet_train/lib/bullet_train.rb +++ b/bullet_train/lib/bullet_train.rb @@ -73,7 +73,7 @@ def default_url_options_from_base_url end def heroku? - ENV['HEROKU_APP_NAME'].present? + ENV["HEROKU_APP_NAME"].present? end def inbound_email_enabled?