Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test examples are created right with all callbacks etc. #526

Closed
newstler opened this issue Sep 6, 2023 · 1 comment
Closed

Test examples are created right with all callbacks etc. #526

newstler opened this issue Sep 6, 2023 · 1 comment
Assignees

Comments

@newstler
Copy link
Contributor

newstler commented Sep 6, 2023

There was a reason why we used .create method in FactoryBot.example instead of .build. Current tests don't catch if anything's changed when we switch to .build. We need to write tests that prove or refute that .create has being used for purpose.

.build is proposed in:
#524
bullet-train-co/bullet_train#965

@newstler
Copy link
Contributor Author

Late update: it appeared that current tests detect those quite well so the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant