Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Showcase Example for Field Partials #188

Merged
merged 11 commits into from
Aug 12, 2023
Merged

Conversation

ps-ruby
Copy link
Contributor

@ps-ruby ps-ruby commented Mar 12, 2023

This is still work in the process. I am just done adding the all available partials fields.

@kaspth
Copy link
Contributor

kaspth commented Mar 14, 2023

@ps-ruby nice, let me know when this is ready for review then I'll look through them.

@ps-ruby
Copy link
Contributor Author

ps-ruby commented Mar 15, 2023

@ps-ruby nice, let me know when this is ready for a review then I'll look through them.

Sure

@andrewculver has asked me to add a showcase for theme partials and I have overlooked the requirement and added for field partial. Anyway, I will complete it and let you know.

@jagthedrummer jagthedrummer marked this pull request as draft August 2, 2023 21:29
@jagthedrummer
Copy link
Contributor

Hey @ps-ruby, just curious if you're planning to finish this out, or if we should close it.

@kaspth
Copy link
Contributor

kaspth commented Aug 9, 2023

Actually, let me take this over unless you want to @ps-ruby 😄

@ps-ruby
Copy link
Contributor Author

ps-ruby commented Aug 10, 2023

Actually, let me take this over unless you want to @ps-ruby 😄

@kaspth You can take over, sorry for keeping it on hold for so long.

@kaspth kaspth marked this pull request as ready for review August 12, 2023 00:22
@kaspth
Copy link
Contributor

kaspth commented Aug 12, 2023

Looks like we're missing some JavaScript to get some of these fields to work. It also looks like the starter repo only imports the trixEditor from fields https://github.com/bullet-train-co/bullet_train/blob/2836a0e4e62b0c0612b88573b7ad9218a852ce2f/app/javascript/application.js#L27

…so I'm not sure how these fields work in Bullet Train apps.

@jagthedrummer
Copy link
Contributor

@kaspth when I grep for fields I'm seeing a couple of more imports in the starter repo.

app/javascript/application.js:import { trixEditor } from "@bullet-train/fields"
app/javascript/controllers/index.js:import { controllerDefinitions as bulletTrainFieldControllers } from "@bullet-train/fields"
app/javascript/intl-tel-input-utils.js:import "@bullet-train/fields/app/assets/javascripts/intl-tel-input-utils.js"

@kaspth
Copy link
Contributor

kaspth commented Aug 12, 2023

I'd accidentally broken including the application assets in Showcase in #378, so I'm fixing that here #403 — after that, the JavaScript works again.

@kaspth
Copy link
Contributor

kaspth commented Aug 12, 2023

Noticed this, which will be a fix later:

[Warning] Please replace data-target="fields--emoji-picker.display" with data-fields--emoji-picker-target="display". The data-target attribute is deprecated and will be removed in a future version of Stimulus. –
<span data-target="fields--emoji-picker.display">😘</span>

@kaspth
Copy link
Contributor

kaspth commented Aug 12, 2023

Ok, I think this puts us in a much better spot than we were before, thanks for @ps-ruby for the groundwork on this!

@kaspth kaspth merged commit 4c0c5ed into main Aug 12, 2023
1 check passed
@kaspth kaspth deleted the showcase-field-partails branch August 12, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants