-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Showcase Example for Field Partials #188
Conversation
@ps-ruby nice, let me know when this is ready for review then I'll look through them. |
Sure @andrewculver has asked me to add a showcase for theme partials and I have overlooked the requirement and added for field partial. Anyway, I will complete it and let you know. |
Hey @ps-ruby, just curious if you're planning to finish this out, or if we should close it. |
Actually, let me take this over unless you want to @ps-ruby 😄 |
Looks like we're missing some JavaScript to get some of these fields to work. It also looks like the starter repo only imports the …so I'm not sure how these fields work in Bullet Train apps. |
@kaspth when I grep for
|
Noticed this, which will be a fix later:
|
Ok, I think this puts us in a much better spot than we were before, thanks for @ps-ruby for the groundwork on this! |
This is still work in the process. I am just done adding the all available partials fields.