From d0b8898e668f48403b82219c9cff317be76829e8 Mon Sep 17 00:00:00 2001 From: gazayas Date: Wed, 16 Aug 2023 19:05:55 +0900 Subject: [PATCH 1/3] Add temporary fix for TangibleThing order --- .../scaffolding/absolutely_abstract/creative_concept.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb b/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb index a4ae478f5..7f5ff1f8f 100644 --- a/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb +++ b/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb @@ -4,7 +4,9 @@ class Scaffolding::AbsolutelyAbstract::CreativeConcept < ApplicationRecord belongs_to :team # 🚅 add belongs_to associations above. - has_many :completely_concrete_tangible_things, class_name: "Scaffolding::CompletelyConcrete::TangibleThing", foreign_key: :absolutely_abstract_creative_concept_id, dependent: :destroy + # TODO: We shouldn't have to explicitly set the order to :asc here, so we need to find out why these records + # are being returned in descending order when calling @creative_concept.completely_concrete_tangible_things. + has_many :completely_concrete_tangible_things, -> { order(created_at: :asc) }, class_name: "Scaffolding::CompletelyConcrete::TangibleThing", foreign_key: :absolutely_abstract_creative_concept_id, dependent: :destroy has_many :collaborators, class_name: "Scaffolding::AbsolutelyAbstract::CreativeConcepts::Collaborator", dependent: :destroy, foreign_key: :creative_concept_id has_many :memberships, through: :collaborators # 🚅 add has_many associations above. From 00a7e9d445e73c0c4a24d1cb7ab7af35a1d87561 Mon Sep 17 00:00:00 2001 From: gazayas Date: Wed, 16 Aug 2023 19:10:55 +0900 Subject: [PATCH 2/3] Write simpler solution --- .../models/scaffolding/absolutely_abstract/creative_concept.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb b/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb index 7f5ff1f8f..52c30c56b 100644 --- a/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb +++ b/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb @@ -6,7 +6,7 @@ class Scaffolding::AbsolutelyAbstract::CreativeConcept < ApplicationRecord # TODO: We shouldn't have to explicitly set the order to :asc here, so we need to find out why these records # are being returned in descending order when calling @creative_concept.completely_concrete_tangible_things. - has_many :completely_concrete_tangible_things, -> { order(created_at: :asc) }, class_name: "Scaffolding::CompletelyConcrete::TangibleThing", foreign_key: :absolutely_abstract_creative_concept_id, dependent: :destroy + has_many :completely_concrete_tangible_things, -> { order(:id) }, class_name: "Scaffolding::CompletelyConcrete::TangibleThing", foreign_key: :absolutely_abstract_creative_concept_id, dependent: :destroy has_many :collaborators, class_name: "Scaffolding::AbsolutelyAbstract::CreativeConcepts::Collaborator", dependent: :destroy, foreign_key: :creative_concept_id has_many :memberships, through: :collaborators # 🚅 add has_many associations above. From dd267ecc58f666c3c1d33e8b6a46df57ac80c813 Mon Sep 17 00:00:00 2001 From: gazayas Date: Wed, 16 Aug 2023 19:11:44 +0900 Subject: [PATCH 3/3] Update comment --- .../models/scaffolding/absolutely_abstract/creative_concept.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb b/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb index 52c30c56b..ca1a96999 100644 --- a/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb +++ b/bullet_train-super_scaffolding/app/models/scaffolding/absolutely_abstract/creative_concept.rb @@ -4,7 +4,7 @@ class Scaffolding::AbsolutelyAbstract::CreativeConcept < ApplicationRecord belongs_to :team # 🚅 add belongs_to associations above. - # TODO: We shouldn't have to explicitly set the order to :asc here, so we need to find out why these records + # TODO: We shouldn't have to explicitly set the order here, so we need to find out why these records # are being returned in descending order when calling @creative_concept.completely_concrete_tangible_things. has_many :completely_concrete_tangible_things, -> { order(:id) }, class_name: "Scaffolding::CompletelyConcrete::TangibleThing", foreign_key: :absolutely_abstract_creative_concept_id, dependent: :destroy has_many :collaborators, class_name: "Scaffolding::AbsolutelyAbstract::CreativeConcepts::Collaborator", dependent: :destroy, foreign_key: :creative_concept_id