Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memberships API #725

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Memberships API #725

merged 1 commit into from
Aug 22, 2023

Conversation

newstler
Copy link
Contributor

@newstler newstler commented Apr 9, 2023

That implements memberships API, adds OpenAPI specs, and fixes path examples generation.
Required by bullet-train-co/bullet_train-core#237

@newstler newstler marked this pull request as draft April 20, 2023 13:33
@newstler newstler marked this pull request as ready for review April 20, 2023 22:59
@jagthedrummer
Copy link
Contributor

Hey @newstler, is this still something that you'd like to see merged. If so, would you mind rebasing/merging main and making sure that tests are passing?

@newstler
Copy link
Contributor Author

Hey @jagthedrummer, sure! Take also a look at #749 (and bullet-train-co/bullet_train-core#270) please! Very much awaited!

@newstler
Copy link
Contributor Author

Updated! I still don't know how to run tests here against a specific branch in a core repo, that's why tests are falling.

@jagthedrummer
Copy link
Contributor

Hey @newstler, the Core: tests in Circle will automatically run against a matching branch in the core repo if it can find one. Since your branches are named features/api-memberships in both repos we're running those tests against your changes in core. The ones that are failing here are are the Release: tests, which we purposefully run against the currently-released versions of the gems.

This helps us know when we're introducing a breaking change into the starter repo because of dependencies on new versions of the gems. These failures basically mean that we need to merge the changes in core, then release new versions of the gems, then merge this PR, and then cut a new release of the starter repo.

@jagthedrummer jagthedrummer merged commit cf87c1e into main Aug 22, 2023
@jagthedrummer jagthedrummer deleted the features/api-memberships branch August 22, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants