Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add middleware/handler to throttle requests to conform to API rate limit #72

Open
2 tasks done
OGKevin opened this issue Jan 31, 2018 · 1 comment
Open
2 tasks done

Add middleware/handler to throttle requests to conform to API rate limit #72

OGKevin opened this issue Jan 31, 2018 · 1 comment
Assignees
@OGKevin
Labels
enhancement

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Jan 31, 2018

Steps to reproduce:

  1. Trigger a 429 response

What should happen:

  1. You the SDK retries after a few seconds

What happens:

  1. The user has to do this him/her self

Traceback

SDK version and environment

  • Tested on 0.12.4
  • Sandbox
  • Production

Response id

  • Response id:

Extra info:
@OGKevin OGKevin added this to the 0.13.0 milestone Jan 31, 2018
@OGKevin OGKevin self-assigned this Jan 31, 2018
@OGKevin OGKevin modified the milestones: 0.13.0, 0.13.5 Mar 27, 2018
@OGKevin OGKevin removed this from the 0.13.5 milestone Jun 1, 2018
@tubbynl
Copy link
Contributor

tubbynl commented Jun 15, 2018 •
edited
Loading

i think it makes more sense to abstract the http(client) handling so that users can inject/replace it with their own handling.

ApiClient mostly fulfills that responsibility already so it makes sense to use that as base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tubbynl @OGKevin