Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce positive timestamps and maximal gaps #16

Open
yannbolliger opened this issue Sep 11, 2019 · 1 comment
Open

Enforce positive timestamps and maximal gaps #16

yannbolliger opened this issue Sep 11, 2019 · 1 comment

Comments

@yannbolliger
Copy link

The timestamp of value 0 is somewhat specially treated by the library and used as initialiser for the field storedTimestamp in both compression & decompression.
This leads to a number of strange behaviours if in the middle of a series some timestamp is 0.

It might be a good idea to disallow all non-positive timestamps to protect users from those behaviours.

Also, the same could be applied for timestamps that are too far apart in time.

@burmanm
Copy link
Owner

burmanm commented Jan 13, 2020

Yes, the storedTimestamp could be changed to something else or a boolean instead to detect the initialization part.

The other issues are a bit more tricky and more related to the application using them, due to way the original paper was written. The application using the library should take care of the block management, so writing a timestamp too far was never an issue that the library has to manage. Same applies to the negative timestamps, if we follow the original paper (in-order inserts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants