From 6ec336f4a125ca606fef4b3f0eaeb200cf2f04eb Mon Sep 17 00:00:00 2001
From: Sergey Astapov <sergeastapov@gmail.com>
Date: Tue, 9 Jul 2024 11:35:36 -0400
Subject: [PATCH] drop support for Ember versions older than 4.8

---
 .github/workflows/ci.yml      |  1 +
 README.md                     |  2 +-
 ember-lazy-mount/package.json |  3 +--
 pnpm-lock.yaml                | 10 +++++++---
 test-app/config/ember-try.js  |  8 ++++++++
 5 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index df3269e..cb44c27 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -62,6 +62,7 @@ jobs:
       fail-fast: false
       matrix:
         try-scenario:
+          - ember-lts-4.8
           - ember-lts-4.12
           - ember-lts-5.4
           - ember-lts-5.8
diff --git a/README.md b/README.md
index 2c9fa01..faa4c60 100644
--- a/README.md
+++ b/README.md
@@ -14,7 +14,7 @@
 
 ## Compatibility
 
-- Ember.js v4.12 or above
+- Ember.js v4.8 or above
 - Embroider or ember-auto-import v2
 
 ## Installation
diff --git a/ember-lazy-mount/package.json b/ember-lazy-mount/package.json
index 69fdbb6..67662a2 100644
--- a/ember-lazy-mount/package.json
+++ b/ember-lazy-mount/package.json
@@ -32,7 +32,6 @@
   "dependencies": {
     "@ember/test-waiters": "^3.1.0",
     "@embroider/addon-shim": "^1.8.7",
-    "@embroider/macros": "^1.16.5",
     "decorator-transforms": "^2.0.0"
   },
   "devDependencies": {
@@ -55,7 +54,7 @@
     "rollup": "^4.18.1"
   },
   "peerDependencies": {
-    "ember-source": ">= 4.0.0"
+    "ember-source": "^4.8.0 || >= 5"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index c47318d..61054c5 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -16,9 +16,6 @@ importers:
       '@embroider/addon-shim':
         specifier: ^1.8.7
         version: 1.8.9
-      '@embroider/macros':
-        specifier: ^1.16.5
-        version: 1.16.5
       decorator-transforms:
         specifier: ^2.0.0
         version: 2.0.0(@babel/core@7.24.7)
@@ -1990,6 +1987,7 @@ packages:
       semver: 7.6.2
     transitivePeerDependencies:
       - supports-color
+    dev: true
 
   /@embroider/shared-internals@2.6.2:
     resolution: {integrity: sha512-jL3Bjn8C73AUBlTex+VixP7YmqvPNN/BZFB85odTstzLFOuR8y2mmGiuWbq17qNuFyoxc6xtndMnAeqwCXBNkA==}
@@ -3346,6 +3344,7 @@ packages:
 
   /assert-never@1.3.0:
     resolution: {integrity: sha512-9Z3vxQ+berkL/JJo0dK+EY3Lp0s3NtSnP3VCLsh5HDcZPrh0M+KQRK5sWhUeyPPH+/RCxZqOxLMR+YC6vlviEQ==}
+    dev: true
 
   /assign-symbols@1.0.0:
     resolution: {integrity: sha512-Q+JC7Whu8HhmTdBph/Tq59IoRtoy6KAm5zzPv00WdujX82lbAL8K7WVjne7vdCsAmbF4AYaDOPyO3k0kl8qIrw==}
@@ -7219,6 +7218,7 @@ packages:
     dependencies:
       locate-path: 6.0.0
       path-exists: 4.0.0
+    dev: true
 
   /find-up@7.0.0:
     resolution: {integrity: sha512-YyZM99iHrqLKjmt4LJDj58KI+fYyufRLBSYcqycxf//KpBk9FoewoGX0450m9nB44qrZnovzC2oeP5hUibxc/g==}
@@ -8853,6 +8853,7 @@ packages:
     engines: {node: '>=10'}
     dependencies:
       p-locate: 5.0.0
+    dev: true
 
   /locate-path@7.2.0:
     resolution: {integrity: sha512-gvVijfZvn7R+2qyPX8mAuKcFGDf6Nc61GdvGafQsHL0sBIxfKzA+usWn4GFC/bk+QdwPUD4kWFJLhElipq+0VA==}
@@ -9785,6 +9786,7 @@ packages:
     engines: {node: '>=10'}
     dependencies:
       yocto-queue: 0.1.0
+    dev: true
 
   /p-limit@4.0.0:
     resolution: {integrity: sha512-5b0R4txpzjPWVw/cXXUResoD4hb6U/x9BH08L7nw+GN1sezDzPdxeRvpc9c433fZhBan/wusjbCsqwqm4EIBIQ==}
@@ -9817,6 +9819,7 @@ packages:
     engines: {node: '>=10'}
     dependencies:
       p-limit: 3.1.0
+    dev: true
 
   /p-locate@6.0.0:
     resolution: {integrity: sha512-wPrq66Llhl7/4AGC6I+cqxT07LhXvWL08LNXz1fENOw0Ap4sRZZ/gZpTTJ5jpurzzzfS2W/Ge9BY3LgLjCShcw==}
@@ -12579,6 +12582,7 @@ packages:
   /yocto-queue@0.1.0:
     resolution: {integrity: sha512-rVksvsnNCdJ/ohGc6xgPwyN8eheCxsiLM8mxuE/t/mOVqJewPuO1miLpTHQiRgTKCLexL4MeAFVagts7HmNZ2Q==}
     engines: {node: '>=10'}
+    dev: true
 
   /yocto-queue@1.1.1:
     resolution: {integrity: sha512-b4JR1PFR10y1mKjhHY9LaGo6tmrgjit7hxVIeAmyMw3jegXR4dhYqLaQF5zMXZxY7tLpMyJeLjr1C4rLmkVe8g==}
diff --git a/test-app/config/ember-try.js b/test-app/config/ember-try.js
index 023e676..ca31431 100644
--- a/test-app/config/ember-try.js
+++ b/test-app/config/ember-try.js
@@ -7,6 +7,14 @@ module.exports = async function () {
   return {
     usePnpm: true,
     scenarios: [
+      {
+        name: 'ember-lts-4.8',
+        npm: {
+          devDependencies: {
+            'ember-source': '~4.8.0',
+          },
+        },
+      },
       {
         name: 'ember-lts-4.12',
         npm: {