From 6c33f8845695356a2d481b2a92b5dc89649bf9e3 Mon Sep 17 00:00:00 2001
From: Matt Dancho <mdancho@gmail.com>
Date: Fri, 31 May 2024 16:41:01 -0400
Subject: [PATCH] #31 fixes issue with metric not being specified

---
 DESCRIPTION             |  2 +-
 NEWS.md                 | 11 +++++++++++
 R/ensemble_model_spec.R |  2 +-
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/DESCRIPTION b/DESCRIPTION
index f79a2d1..12d2dd5 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -52,6 +52,6 @@ Suggests:
     lubridate,
     knitr,
     rmarkdown
-RoxygenNote: 7.2.3
+RoxygenNote: 7.3.1
 VignetteBuilder: knitr
 Roxygen: list(markdown = TRUE)
diff --git a/NEWS.md b/NEWS.md
index 197d8e0..72a0f82 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,5 +1,16 @@
 # modeltime.ensemble (development version)
 
+- #31 Fixes issue with metric argument not being specified:
+
+```r 
+Error in `tune::show_best()`:
+! `...` must be empty.
+✖ Problematic argument:
+• ..1 = metric
+ℹ Did you forget to name an argument?
+```
+
+
 # modeltime.ensemble 1.0.3
 
 - Resubmit to CRAN  (following timetk archival)
diff --git a/R/ensemble_model_spec.R b/R/ensemble_model_spec.R
index c3f0726..6ab221b 100644
--- a/R/ensemble_model_spec.R
+++ b/R/ensemble_model_spec.R
@@ -309,7 +309,7 @@ generate_stacking_results <- function(object,
             )
         )
 
-        best_params_tbl <- tune_results_tbl %>% tune::show_best(metric, n = 1)
+        best_params_tbl <- tune_results_tbl %>% tune::show_best(metric = metric, n = 1)
 
         if (control$verbose) {
             cli::cli_alert_success("Finished tuning Model Specification.")