Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase "Bikely parkering" to something more generic #120

Closed
leonardehrenfried opened this issue Apr 17, 2024 · 9 comments
Closed

Rephrase "Bikely parkering" to something more generic #120

leonardehrenfried opened this issue Apr 17, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@leonardehrenfried
Copy link
Contributor

I've added Bikeep realtime parking information today however, the legend still talks about "Bikely parkering".

image

@tsobuskerudbyen Can you come up with a more generic label?

@tsobuskerudbyen
Copy link

Documented here. #102 (comment)

We need to discuss the number of items in the legend later. For now Bikeep should be seprate from Bikely.

@tsobuskerudbyen tsobuskerudbyen added the enhancement New feature or request label Apr 17, 2024
@tsobuskerudbyen
Copy link

@leonardehrenfried: Can you look at this one or assign to Beck-berry?

@leonardehrenfried
Copy link
Contributor Author

@Beck-berry can you please take care of it?

@Beck-berry Beck-berry moved this to Todo in Cycling Norway May 18, 2024
@Beck-berry Beck-berry moved this from Todo to In Progress in Cycling Norway May 18, 2024
@Beck-berry
Copy link
Contributor

We can create a switch in the legend for separate layers only.
Since @tsobuskerudbyen wants Bikeep and Bikely to be separate, is there a way to add them as seperate layers, @leonardehrenfried? Do I understand right, you added the Bikeep data to the byvekstavtale.leonard.io/tiles/bikely.json file? Shouldn't be there a bikeep.json? That way I could add a different icon and switch to the legend.

@leonardehrenfried
Copy link
Contributor Author

leonardehrenfried commented May 28, 2024

At the moment, this is not possible. I will need to configure that.

Putting that on my todo list.

@Beck-berry Beck-berry removed their assignment Jun 2, 2024
@leonardehrenfried
Copy link
Contributor Author

@Beck-berry
Copy link
Contributor

@leonardehrenfried I changed the bikely source and added the bikeep layer (you can check the connected commit) but somehow they do not appear, however both requests got an OK response. Do you have an idea what's wrong? I'll keep investigating on this otherwise.

@leonardehrenfried
Copy link
Contributor Author

I think I know what the problem is and I'm taking a look today.

@leonardehrenfried
Copy link
Contributor Author

I have now fixed both the backend and the frontend and Bikeep and Bikely show up as different layers.

In Sandvika you can see both on the same screen: https://sykkelveier.no/?layers=anlegg%2Crute-nb%2Crute-lb%2Crute-no%2Crute-lo%2Cpoffentlig%2Cpprivat%2Cpskap%2Cphotell%2Cptak%2Crep%2Cbr%C3%B8yting-ok%2Cbr%C3%B8yting-senere%2Csn%C3%B8r%2Cpumpe%2Cbutikk%2Cpumptrack%2Cloype%2Cbikely%2Cbikeep%2Clavhastighet#13.36/59.89325/10.53658

I would suggest to close this ticket and @tsobuskerudbyen and @Beck-berry can work on the fine-tuning of the look and feel over at #102.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Cycling Norway Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants