Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename base Menu component to Header for consistency #536

Open
BCerki opened this issue Oct 7, 2022 · 0 comments
Open

Rename base Menu component to Header for consistency #536

BCerki opened this issue Oct 7, 2022 · 0 comments

Comments

@BCerki
Copy link
Contributor

BCerki commented Oct 7, 2022 •
edited
Loading

We have a base component called Menu but both themes import it into their Header components. Consider renaming the base one one to Header for consistency, but will require careful release ordering and versioning
@BCerki BCerki self-assigned this Oct 7, 2022
@BCerki BCerki removed their assignment Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BCerki