Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callout's Storybook preview does not change when controls are used #554

Open
joshgamache opened this issue Oct 14, 2022 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@joshgamache
Copy link
Contributor

joshgamache commented Oct 14, 2022

Specifications

@button-inc/component-library 1.0.3

Describe the bug

When changing any of the controls in the Callout component's Storybook, the preview does not change. This impacts both the Button and BCGov themes. the BCGOV theme. To fix:

  • in the Story file, add to content to args and spread the args in the Callout component (see Button Callout for an example)
  • more?

How to reproduce

  1. Access the deployed Storybook or run locally with yarn storybook:<theme>.
  2. Navigate to the Callout component.
  3. Change the Size and/or Content control(s).
  4. Observe the preview.

Expected behavior

The preview should change to reflect the changes made in the controls.

Additional context

The displayed text in the preview is passed through as a child.

@joshgamache joshgamache added the bug Something isn't working label Oct 14, 2022
@BallardRobinett BallardRobinett self-assigned this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants