bz_GetSpikes.m has redundant/crashy load waveforms

[brendonw1]

There are two parts of bz_GetSpikes that load spike waveforms and the newer/second one causes crashes if no .dat file - and is also redundant with the earlier part.

Summary:

• Waveform load 1: Loads waveforms from .spks (old fashoned, not usually present, but sometimes), doesn't use .dat, but is only applicable in old datasets
• Waveform load 2: Loads waveforms from .dats, but for some reason ALWAYS does this, even if waveforms are already there and causes crashes in old datasets wihtout .dats.

So I propose: to make the second part only get called if the first part didn't.

Agree?

[brendonw1]

... also put an "if" so second part doesn't crash the whole bz_getspikes but just gives an error

[AntonioFR8]

Yes, that sounds good to me. thanks

…

On Aug 17, 2020, at 3:33 PM, Brendon Watson ***@***.***> wrote: ... also put an "if" so second part doesn't crash the whole bz_getspikes but just gives an error — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#394 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHSQQZUBW5OESLBXJC2JJTSBGAYLANCNFSM4QCC3QKA>.

[brendonw1]

Awesome will do.
Actually noticed one thing - there is a param called keepCluWave.
keepCluWave is default false and I can assume from how it's written that it's used to so it will always load from .dat even when .spk is present. I'll set so that still happens (overwrite .spk using .dat-based waves) if possible, but won't if error.

Just putting this all here in case I'm misunderstanding the intentions of the person who wrote this. Otherwise I'll do as I said.
Thanks.