Fix new IDEA insepections

bwRavencl · Dec 6, 2023 · d84312b · d84312b
1 parent aac3102
commit d84312b
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 12 deletions.
diff --git a/src/main/java/de/bwravencl/controllerbuddy/gui/EditActionsDialog.java b/src/main/java/de/bwravencl/controllerbuddy/gui/EditActionsDialog.java
@@ -189,7 +189,7 @@ public EditActionsDialog(
         setTitle(MessageFormat.format(Main.strings.getString("EDIT_ACTIONS_DIALOG_TITLE_COMPONENT_EDITOR"), name));
 
         final var modes = unsavedProfile.getModes();
-        selectedMode = modes.get(0);
+        selectedMode = modes.getFirst();
         GuiUtils.addModePanel(getContentPane(), modes, new AbstractAction() {
 
             @Serial

diff --git a/src/main/java/de/bwravencl/controllerbuddy/gui/Main.java b/src/main/java/de/bwravencl/controllerbuddy/gui/Main.java
@@ -963,7 +963,7 @@ public void windowOpened(final WindowEvent e) {
                                 },
                                 () -> {
                                     log.log(Level.INFO, "Previously used controller is not present");
-                                    setSelectedController(presentControllers.get(0));
+                                    setSelectedController(presentControllers.getFirst());
                                 });
             }
         }
@@ -2209,7 +2209,7 @@ private void onControllersChanged(final List<ControllerInfo> presentControllers,
         if (!controllerConnected) {
             selectedController = null;
         } else if (selectedController == null) {
-            setSelectedControllerAndUpdateInput(presentControllers.get(0), null);
+            setSelectedControllerAndUpdateInput(presentControllers.getFirst(), null);
             updateTitleAndTooltip();
 
             if (isAutoRestartOutput()) {

diff --git a/src/main/java/de/bwravencl/controllerbuddy/gui/OpenVrOverlay.java b/src/main/java/de/bwravencl/controllerbuddy/gui/OpenVrOverlay.java
@@ -407,11 +407,7 @@ private void updateOverlay(final long overlayHandle, final Frame frame) {
                 checkOverlayError(VROverlay.VROverlay_ShowOverlay(overlayHandle));
 
                 if (VROverlay.VROverlay_IsOverlayVisible(overlayHandle)) {
-                    var textureData = textureDataCache.get(overlayHandle);
-                    if (textureData == null) {
-                        textureData = new TextureData();
-                        textureDataCache.put(overlayHandle, textureData);
-                    }
+                    final var textureData = textureDataCache.computeIfAbsent(overlayHandle, k -> new TextureData());
 
                     final var imageResized = textureData.image == null
                             || textureData.image.getWidth() != frame.getWidth()

diff --git a/src/main/java/de/bwravencl/controllerbuddy/input/Input.java b/src/main/java/de/bwravencl/controllerbuddy/input/Input.java
@@ -469,7 +469,7 @@ public boolean poll() {
                 }
 
                 if (actions == null) {
-                    actions = modes.get(0).getAxisToActionsMap().get(axis);
+                    actions = modes.getFirst().getAxisToActionsMap().get(axis);
                 }
 
                 if (actions != null) {
@@ -497,7 +497,7 @@ public boolean poll() {
                 }
 
                 if (actions == null) {
-                    actions = modes.get(0).getButtonToActionsMap().get(button);
+                    actions = modes.getFirst().getButtonToActionsMap().get(button);
                 }
 
                 if (actions != null) {

diff --git a/src/main/java/de/bwravencl/controllerbuddy/input/action/ButtonToModeAction.java b/src/main/java/de/bwravencl/controllerbuddy/input/action/ButtonToModeAction.java
@@ -122,7 +122,7 @@ private void deactivateMode(final Input input, final Profile profile) {
         if (previousButtonToModeAction != null) {
             previousMode = previousButtonToModeAction.getMode(input);
         } else {
-            previousMode = profile.getModes().get(0);
+            previousMode = profile.getModes().getFirst();
         }
 
         final var activeMode = profile.getActiveMode();

diff --git a/src/main/java/de/bwravencl/controllerbuddy/input/driver/EvdevDriver.java b/src/main/java/de/bwravencl/controllerbuddy/input/driver/EvdevDriver.java
@@ -288,7 +288,7 @@ public Driver getIfAvailable(
                 }
 
                 try {
-                    return new EvdevDriver(input, selectedController, evdevInfos.get(0));
+                    return new EvdevDriver(input, selectedController, evdevInfos.getFirst());
                 } catch (final IOException e) {
                     log.log(Level.SEVERE, e.getMessage(), e);
                 }