Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On windows, using a DNS hostname in redisWorker causes long-running jobs to all timeout #13

Open
patcpsc opened this issue Sep 12, 2014 · 2 comments

Comments

@patcpsc
Copy link

patcpsc commented Sep 12, 2014

On windows, there's no lookup in alive.c to find the remote host IP. So specifying "localhost" as the default host causes the "alive" tag writing to fail. This means the master detects all long-running jobs as failures, then restarts them despite the worker finishing them.

@bwlewis
Copy link
Owner

bwlewis commented Sep 15, 2014

Hi, sorry for the latency--been on vacation!

This bug you've encountered is confusing. I think the host lookup is OK. gethostbyname is deprecated in Windows, in favor of getaddrinfo, which is used in the alive.c code. See for example:

http://msdn.microsoft.com/en-us/library/windows/desktop/ms738524(v=vs.85).aspx
http://msdn.microsoft.com/en-us/library/windows/desktop/ms738520(v=vs.85).aspx

So now I wonder where the problem is? Any ideas?
Thanks again for the fix to rredis, greatly appreciated!

@bwlewis bwlewis closed this as completed Sep 15, 2014
@bwlewis bwlewis reopened this Sep 15, 2014
@bwlewis
Copy link
Owner

bwlewis commented Sep 15, 2014

sorry, accidentally hit close instead of comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants