Replies: 2 comments 1 reply
-
Not sure about |
Beta Was this translation helpful? Give feedback.
1 reply
-
In addition of my initial proposition :
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi everyone !
When I Add GuildScheduledEvents on discordgo (#1032), I have seen several errors in the code and its organization that could be harmonized and tidied up.
I will list these changes below and if accepted, I would like to convert this into a milestone grouping several PRs to make these changes:
restapi.go
uri and url is used without specific logic and maybe can be cleaned tourl
, following the URL convention (Add Guild Scheduled Event Support #1032 (comment), thanks to @FedorLap2006)structs.go
, we can think only contain struct, include custom struct helper and Marshal/Unmarshal function, this can be good to move functions on separated file (ex:marshal.go
)types.go
contains onlyerror
, maybe rename iterror.go
Any others changes, any discussions about it are welcome !
Beta Was this translation helpful? Give feedback.
All reactions