Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: automated releases need to consider wit test #1915

Closed
Robbepop opened this issue Nov 27, 2024 · 1 comment · Fixed by #1916
Closed

bug: automated releases need to consider wit test #1915

Robbepop opened this issue Nov 27, 2024 · 1 comment · Fixed by #1916
Labels
bug Something isn't working

Comments

@Robbepop
Copy link
Collaborator

Robbepop commented Nov 27, 2024 •
edited
Loading

When publishing a new major wasm-tools version the scripts stumbled upon a test that was not properly updated:

Publish PR: #1914
Problematic test: b3ac2d1

The fix was trivial: changing 220 to 221 but this should be included in the automated scripts OR should not need adjustment at all.

cc @alexcrichton
@Robbepop Robbepop added the bug Something isn't working label Nov 27, 2024
pchickey added a commit that referenced this issue Nov 27, 2024
@pchickey
cli tests: mask the version of wit-component in producers section in …
b86709b 
…the test output

Closes #1915
@pchickey pchickey mentioned this issue Nov 27, 2024
Merged
@pchickey
Copy link
Contributor

This bit me too so I did a probably not that questionable fix in #1916.

github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2024
@pchickey
cli tests: mask the version of wit-component in producers section in …
77122f1 
…the test output (#1916)

Closes #1915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@pchickey @Robbepop