feat: impl spawn_catch_unwind() #319
Conversation
| /// In this example, a server is started and `spawn` is used to start a new task | ||
| /// that processes each received connection. | ||
| /// |
There was a problem hiding this comment.
This is a copy-paste error, since the provided example is not a TCP server, let's just remove this sentence.
SteveLauC
force-pushed
the
feat/catch_panic
branch
from
1674877
to
37515bf
Compare
| T: Future + 'static, | ||
| T::Output: 'static, | ||
| { | ||
| use futures::{FutureExt, TryFutureExt}; |
There was a problem hiding this comment.
Using futures_util instead of futures can reduce dependencies. Or fork CatchUnwind can avoid introducing new dependency.
There was a problem hiding this comment.
Or fork CatchUnwind can avoid introducing new dependency.
Yeah, this makes more sense
There was a problem hiding this comment.
Could you change in any of these 2 ways?
Note if you choose to fork code, remember to add enough note for the copyright.
There was a problem hiding this comment.
Could you change in any of these 2 ways?
Yeah, I will, I am just busy with my work.
Note if you choose to fork code, remember to add enough note for the copyright.
Get it.
What does this PR do
Adds a new spawn function that will catch the spawned task's panic.
Closes #314